Allow to configure the compress algorithm in mysqldump and pg_dump #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denzelem
force-pushed
the
ed/add-compress-algorithm-to-dumple
branch
from
3842c12 to
7ada19c
Compare
codener
requested changes
Sep 16, 2025
Member
codener
left a comment
codener
left a comment
There was a problem hiding this comment.
Thanks for this PR! I have a few remarks, please have a look.
denzelem
force-pushed
the
ed/add-compress-algorithm-to-dumple
branch
from
7ada19c to
8e6ce1a
Compare
codener
approved these changes
Sep 18, 2025
Member
codener
left a comment
codener
left a comment
There was a problem hiding this comment.
Really good now 👌 I just have a generalization request.
codener
approved these changes
Sep 19, 2025
Member
codener
left a comment
codener
left a comment
There was a problem hiding this comment.
Thanks for the update.
As commented, I would prefer to have Util.dumple_command. However, if you're unwilling to do another iteration, I'll accept the current state as well.
denzelem
force-pushed
the
ed/add-compress-algorithm-to-dumple
branch
from
b15bd97 to
22c56ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#238